diff options
| author | Jinjie Ruan <ruanjinjie@huawei.com> | 2024-09-10 20:43:14 +0800 |
|---|---|---|
| committer | Kalle Valo <kvalo@kernel.org> | 2024-09-18 16:54:30 +0300 |
| commit | 5a4d42c1688c88f3be6aef46b0ea6c32694cd2b8 (patch) | |
| tree | 9831d5c6deff767fdce6f764872742bdcecdae46 | |
| parent | 9a98dd48b6d834d7a3fe5e8e7b8c3a1d006f9685 (diff) | |
| download | linux-5a4d42c1688c88f3be6aef46b0ea6c32694cd2b8.tar.gz linux-5a4d42c1688c88f3be6aef46b0ea6c32694cd2b8.zip | |
wifi: wl1251: Use IRQF_NO_AUTOEN flag in request_irq()
As commit cbe16f35bee6 ("genirq: Add IRQF_NO_AUTOEN for request_irq/nmi()")
said, the code below is subobtimal. IRQF_NO_AUTOEN flag can be used by
drivers to request_irq(). It prevents the automatic enabling of the
requested interrupt in the same safe way. With that the usage can be
simplified and corrected.
irq_set_status_flags(irq, IRQ_NOAUTOEN);
request_irq(dev, irq...);
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20240910124314.698896-4-ruanjinjie@huawei.com
| -rw-r--r-- | drivers/net/wireless/ti/wl1251/sdio.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/wireless/ti/wl1251/sdio.c b/drivers/net/wireless/ti/wl1251/sdio.c index c705081249d6..b45050243129 100644 --- a/drivers/net/wireless/ti/wl1251/sdio.c +++ b/drivers/net/wireless/ti/wl1251/sdio.c @@ -233,8 +233,8 @@ static int wl1251_sdio_probe(struct sdio_func *func, } if (wl->irq) { - irq_set_status_flags(wl->irq, IRQ_NOAUTOEN); - ret = request_irq(wl->irq, wl1251_line_irq, 0, "wl1251", wl); + ret = request_irq(wl->irq, wl1251_line_irq, IRQF_NO_AUTOEN, + "wl1251", wl); if (ret < 0) { wl1251_error("request_irq() failed: %d", ret); goto disable; |