diff options
| author | Alessandro Zanni <alessandro.zanni87@gmail.com> | 2025-09-25 15:28:23 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2025-09-26 15:23:33 -0700 |
| commit | 81dcfdd21dbd7067068c7c341ee448c3f0d6f115 (patch) | |
| tree | 675d4fb309fc2f7185698dae5b8e48960c1d57a8 | |
| parent | 793adf57e2cfa85792989f6d89cb1bba5bcc6df2 (diff) | |
| download | linux-81dcfdd21dbd7067068c7c341ee448c3f0d6f115.tar.gz linux-81dcfdd21dbd7067068c7c341ee448c3f0d6f115.zip | |
selftest: net: Fix error message if empty variable
Fix to avoid cases where the `res` shell variable is
empty in script comparisons.
The comparison has been modified into string comparison to
handle other possible values the variable could assume.
The issue can be reproduced with the command:
make kselftest TARGETS=net
It solves the error:
./tfo_passive.sh: line 98: [: -eq: unary operator expected
Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250925132832.9828-1-alessandro.zanni87@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rwxr-xr-x | tools/testing/selftests/net/tfo_passive.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/net/tfo_passive.sh b/tools/testing/selftests/net/tfo_passive.sh index 80bf11fdc046..a4550511830a 100755 --- a/tools/testing/selftests/net/tfo_passive.sh +++ b/tools/testing/selftests/net/tfo_passive.sh @@ -95,7 +95,7 @@ wait res=$(cat $out_file) rm $out_file -if [ $res -eq 0 ]; then +if [ "$res" = "0" ]; then echo "got invalid NAPI ID from passive TFO socket" cleanup_ns exit 1 |