diff options
| author | Minhong He <heminhong@kylinos.cn> | 2026-08-03 16:59:50 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2026-08-04 18:52:57 -0700 |
| commit | 82167f2f0fdec3ce2c418b2dd35408ba74b1f6e3 (patch) | |
| tree | d52bc238958aebd61814de564ab6fba9063eb4b9 | |
| parent | c1293e4a34e2db9f491f2509f812d5c999a2b002 (diff) | |
| download | linux-82167f2f0fdec3ce2c418b2dd35408ba74b1f6e3.tar.gz linux-82167f2f0fdec3ce2c418b2dd35408ba74b1f6e3.zip | |
net: macvlan: check register_netdevice_notifier() error in macvlan_init_module()
macvlan_init_module() ignores register_netdevice_notifier() errors and
continues module initialization, which can leave macvlan loaded without
its netdev notifier registered.
Check the error and fail module initialization early.
This is a future looking check, register_netdevice_notifier()
only fails on double registration or if the registered notifier
itself returns an error.
Signed-off-by: Minhong He <heminhong@kylinos.cn>
Link: https://patch.msgid.link/20260803085950.142325-1-heminhong@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | drivers/net/macvlan.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 42169f3614c4..8d71a832cb17 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -1915,7 +1915,9 @@ static int __init macvlan_init_module(void) { int err; - register_netdevice_notifier(&macvlan_notifier_block); + err = register_netdevice_notifier(&macvlan_notifier_block); + if (err) + return err; err = macvlan_link_register(&macvlan_link_ops); if (err < 0) |