diff options
| author | Ben Dooks <ben.dooks@codethink.co.uk> | 2026-06-17 09:49:43 +0100 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2026-07-02 21:13:58 +0530 |
| commit | 89aba9c39bdda8a973a6ffed7c9e93321edcfc16 (patch) | |
| tree | a69cadfb853af0fcf15ee96eb71d7e1971715ef6 | |
| parent | a6404c7291bcc10114e72e9d0226709ec9d05d5a (diff) | |
| download | linux-89aba9c39bdda8a973a6ffed7c9e93321edcfc16.tar.gz linux-89aba9c39bdda8a973a6ffed7c9e93321edcfc16.zip | |
dmaengine: dw-axi-dmac: fix __le32 on set of CH_CTL_H_LLI_VALID
When writing the lli->ctl_hi, this is an __le32 type so the
value being orred should be convered to __le32 by cpu_to_le32.
Fixes 1deb96c0fa58a ("dmaegine: dw-axi-dmac: Support device_prep_dma_cyclic()")
--
Note, the call to axi_chan_irq_clear() is passing lli->status_lo
through which is also an __le32 but it does not seem to be set
anywhere. Is this also a bug?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Link: https://patch.msgid.link/20260617084944.705266-1-ben.dooks@codethink.co.uk
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c index bcefaff03b5c..eebed2474210 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -1126,7 +1126,7 @@ static void axi_chan_block_xfer_complete(struct axi_dma_chan *chan) hw_desc = &desc->hw_desc[i]; if (hw_desc->llp == llp) { axi_chan_irq_clear(chan, hw_desc->lli->status_lo); - hw_desc->lli->ctl_hi |= CH_CTL_H_LLI_VALID; + hw_desc->lli->ctl_hi |= cpu_to_le32(CH_CTL_H_LLI_VALID); desc->completed_blocks = i; if (((hw_desc->len * (i + 1)) % desc->period_len) == 0) |