summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJori Koolstra <jkoolstra@xs4all.nl>2026-06-30 12:53:45 +0200
committerChristian Brauner <brauner@kernel.org>2026-07-01 12:50:29 +0200
commit950c8f79547c9331f56dfb7fe06f70ee861e49bc (patch)
treed94e405075d856e610533f76815f5ebbec84ec81
parent73c6af95575933388ecd2149816dfaa0185a5f59 (diff)
downloadlinux-950c8f79547c9331f56dfb7fe06f70ee861e49bc.tar.gz
linux-950c8f79547c9331f56dfb7fe06f70ee861e49bc.zip
jffs2: drop redundant S_IFDIR from mkdir
vfs_mkdir() now sets the S_IFDIR type bit in the mode it passes to ->mkdir(), so OR-ing S_IFDIR into the mode again in jffs2_mkdir() is redundant. Drop it. Assisted-by: LLM Signed-off-by: Jori Koolstra <jkoolstra@xs4all.nl> Link: https://patch.msgid.link/20260630105400.68459-17-jkoolstra@xs4all.nl Reviewed-by: NeilBrown <neil@brown.name> Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
-rw-r--r--fs/jffs2/dir.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/jffs2/dir.c b/fs/jffs2/dir.c
index c4088c3b4ac0..2b86adcbd8f4 100644
--- a/fs/jffs2/dir.c
+++ b/fs/jffs2/dir.c
@@ -462,8 +462,6 @@ static struct dentry *jffs2_mkdir (struct mnt_idmap *idmap, struct inode *dir_i,
uint32_t alloclen;
int ret;
- mode |= S_IFDIR;
-
ri = jffs2_alloc_raw_inode();
if (!ri)
return ERR_PTR(-ENOMEM);