diff options
| author | Thadeu Lima de Souza Cascardo <cascardo@igalia.com> | 2026-08-17 15:45:20 -0300 |
|---|---|---|
| committer | Melissa Wen <melissa.srw@gmail.com> | 2026-08-26 05:37:41 -0300 |
| commit | d32b08284f44c20edb2ea3f64ba0a6a165036fb2 (patch) | |
| tree | 794698f78e8d2e9e6d4d98dac688f7f3a30667c9 | |
| parent | 92312d333bf700798f92f30406c721bce87506f3 (diff) | |
| download | linux-d32b08284f44c20edb2ea3f64ba0a6a165036fb2.tar.gz linux-d32b08284f44c20edb2ea3f64ba0a6a165036fb2.zip | |
drm/atomic: remove bogus check for file_priv
Since file_priv can never be NULL at prepare_signaling() as it is only
called by drm_mode_atomic_ioctl(), remove the check.
If that was not the case, skipping the rest of the block here would cause
the drm_pending_vblank_event object to leak and fail to set up the fence in
case out_fence_ptr is set.
Since the check is unreachable, there is no possible leak.
Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Reviewed-by: Melissa Wen <mwen@igalia.com>
Signed-off-by: Melissa Wen <mwen@igalia.com>
Link: https://patch.msgid.link/20260817-drm_atomic_bogus_check-v2-1-2b9e60f32a7e@igalia.com
| -rw-r--r-- | drivers/gpu/drm/drm_atomic_uapi.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/gpu/drm/drm_atomic_uapi.c b/drivers/gpu/drm/drm_atomic_uapi.c index e997917819e8..657c15474ed5 100644 --- a/drivers/gpu/drm/drm_atomic_uapi.c +++ b/drivers/gpu/drm/drm_atomic_uapi.c @@ -1445,9 +1445,6 @@ static int prepare_signaling(struct drm_device *dev, if (arg->flags & DRM_MODE_PAGE_FLIP_EVENT) { struct drm_pending_vblank_event *e = crtc_state->event; - if (!file_priv) - continue; - ret = drm_event_reserve_init(dev, file_priv, &e->base, &e->event.base); if (ret) { |