diff options
| author | Deborah Brouwer <deborah.brouwer@collabora.com> | 2026-04-09 10:51:28 -0700 |
|---|---|---|
| committer | Alice Ryhl <aliceryhl@google.com> | 2026-04-27 18:43:05 +0000 |
| commit | 4cae5d9b3a6bfb5d0b24872fe8edad570c109e89 (patch) | |
| tree | 8a9bd9c69b5c7cfe06a4e32631c6c2cf001d65aa /drivers | |
| parent | bc8dd92ec67e87244b434304ee25eef0ff70da6e (diff) | |
| download | linux-4cae5d9b3a6bfb5d0b24872fe8edad570c109e89.tar.gz linux-4cae5d9b3a6bfb5d0b24872fe8edad570c109e89.zip | |
drm/tyr: Remove custom register struct
Now that Tyr uses the register! macro, it no longer needs to define a
custom register struct or read/write functions, so delete them.
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Co-developed-by: Daniel Almeida <daniel.almeida@collabora.com>
Signed-off-by: Daniel Almeida <daniel.almeida@collabora.com>
Reviewed-by: Daniel Almeida <daniel.almeida@collabora.com>
Signed-off-by: Deborah Brouwer <deborah.brouwer@collabora.com>
Link: https://patch.msgid.link/20260409-b4-tyr-use-register-macro-v5-v5-5-8abfff8a0204@collabora.com
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/gpu/drm/tyr/regs.rs | 33 |
1 files changed, 0 insertions, 33 deletions
diff --git a/drivers/gpu/drm/tyr/regs.rs b/drivers/gpu/drm/tyr/regs.rs index 725e9f191ded..8509093f8f01 100644 --- a/drivers/gpu/drm/tyr/regs.rs +++ b/drivers/gpu/drm/tyr/regs.rs @@ -27,39 +27,6 @@ // does. #![allow(dead_code)] -use kernel::{ - device::{ - Bound, - Device, // - }, - devres::Devres, - io::Io, - prelude::*, // -}; - -use crate::driver::IoMem; - -/// Represents a register in the Register Set -/// -/// TODO: Replace this with the Nova `register!()` macro when it is available. -/// In particular, this will automatically give us 64bit register reads and -/// writes. -pub(crate) struct Register<const OFFSET: usize>; - -impl<const OFFSET: usize> Register<OFFSET> { - #[inline] - pub(crate) fn read(&self, dev: &Device<Bound>, iomem: &Devres<IoMem>) -> Result<u32> { - let value = (*iomem).access(dev)?.read32(OFFSET); - Ok(value) - } - - #[inline] - pub(crate) fn write(&self, dev: &Device<Bound>, iomem: &Devres<IoMem>, value: u32) -> Result { - (*iomem).access(dev)?.write32(value, OFFSET); - Ok(()) - } -} - /// Combine two 32-bit values into a single 64-bit value. pub(crate) fn join_u64(lo: u32, hi: u32) -> u64 { (u64::from(lo)) | ((u64::from(hi)) << 32) |
