diff options
| author | Linmao Li <lilinmao@kylinos.cn> | 2026-07-28 17:16:23 +0800 |
|---|---|---|
| committer | Jassi Brar <jassisinghbrar@gmail.com> | 2026-08-15 15:41:12 -0500 |
| commit | ef24ff4f5cda39f8a2e7da3d57773da8fbe600ce (patch) | |
| tree | cc5730ad3c3ab89e87a0920ff8287b341a740596 /drivers | |
| parent | ded48fcbdc1e3ed1dc8e1974b7fe9639fcea6dd6 (diff) | |
| download | linux-ef24ff4f5cda39f8a2e7da3d57773da8fbe600ce.tar.gz linux-ef24ff4f5cda39f8a2e7da3d57773da8fbe600ce.zip | |
mailbox: rockchip: drop unneeded runtime pointer (pclk)
The pclk pointer is only used in rockchip_mbox_probe() and is not needed
after probe completes.
Make it a local variable and drop it from struct rockchip_mbox, which
saves a little bit of runtime memory.
Signed-off-by: Linmao Li <lilinmao@kylinos.cn>
Signed-off-by: Jassi Brar <jassisinghbrar@gmail.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/mailbox/rockchip-mailbox.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/mailbox/rockchip-mailbox.c b/drivers/mailbox/rockchip-mailbox.c index d55cbf7f2cb6..bc2f9dd798dd 100644 --- a/drivers/mailbox/rockchip-mailbox.c +++ b/drivers/mailbox/rockchip-mailbox.c @@ -40,7 +40,6 @@ struct rockchip_mbox_chan { struct rockchip_mbox { struct mbox_controller mbox; - struct clk *pclk; void __iomem *mbox_base; /* The maximum size of buf for each channel */ @@ -166,6 +165,7 @@ static int rockchip_mbox_probe(struct platform_device *pdev) struct rockchip_mbox *mb; const struct rockchip_mbox_data *drv_data; struct resource *res; + struct clk *pclk; int ret, irq, i; if (!pdev->dev.of_node) @@ -196,9 +196,9 @@ static int rockchip_mbox_probe(struct platform_device *pdev) /* Each channel has two buffers for A2B and B2A */ mb->buf_size = (size_t)resource_size(res) / (drv_data->num_chans * 2); - mb->pclk = devm_clk_get_enabled(&pdev->dev, "pclk_mailbox"); - if (IS_ERR(mb->pclk)) - return dev_err_probe(&pdev->dev, PTR_ERR(mb->pclk), + pclk = devm_clk_get_enabled(&pdev->dev, "pclk_mailbox"); + if (IS_ERR(pclk)) + return dev_err_probe(&pdev->dev, PTR_ERR(pclk), "failed to get and enable pclk_mailbox clock\n"); for (i = 0; i < mb->mbox.num_chans; i++) { |