summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorMarek Czernohous <marek@czernohous.de>2026-08-13 01:13:27 +0200
committerLyude Paul <lyude@redhat.com>2026-08-20 17:33:43 -0400
commit511585987d27d8cb668acebd399fc4deda23404c (patch)
tree9bdb257f6967442f7f3406ee719041547752a6b4 /include
parentdc14753664240cedf669623b27ae9922b0618b25 (diff)
downloadlinux-511585987d27d8cb668acebd399fc4deda23404c.tar.gz
linux-511585987d27d8cb668acebd399fc4deda23404c.zip
drm/nouveau: unsubscribe the channel-kill event before the fence context
nouveau_channel_del() tears the fence context down first and only drops the channel-kill subscription later, in the middle of the nvif object teardown: if (chan->fence) nouveau_fence(chan->cli->drm)->context_del(chan); ... nvif_object_dtor(&chan->vram); nvif_event_dtor(&chan->kill); The subscribed handler is nouveau_channel_killed(), which calls nouveau_channel_kill() and from there nouveau_fence_context_kill() on chan->fence. A kill event delivered in that window takes fctx->lock and walks fctx->pending on a fence context that context_del() has already freed. Nothing reaches this below Fermi today, because the subscription is gated on FERMI_CHANNEL_GPFIFO and nothing kills a channel there. On Fermi and newer the window is real but narrow, since a kill has to land exactly while the channel is being destroyed. That is reason enough on its own, which is why this carries a Fixes: tag. The last patch in this series subscribes Tesla channels as well; nothing kills those today, so it does not widen the exposure now, but it is the groundwork for a recovery path that would, and the ordering is better fixed before that lands than alongside it. Drop the subscription before anything it depends on is torn down. Fixes: ea13e5abf807 ("drm/nouveau: signal pending fences when channel has been killed") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-5 Signed-off-by: Marek Czernohous <marek@czernohous.de> Fixes: ea13e5abf807 ("drm/nouveau: signal pending fences when channel has been killed") Reviewed-by: Lyude Paul <lyude@redhat.com> Signed-off-by: Lyude Paul <lyude@redhat.com> Link: https://patch.msgid.link/20260812231330.705425-2-mczernohous@gmail.com
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions