diff options
| author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2026-08-05 12:10:43 -0300 |
|---|---|---|
| committer | Namhyung Kim <namhyung@kernel.org> | 2026-08-05 21:50:45 -0700 |
| commit | 6d421f609bba7b0b1a11741ec4b19feadfd27051 (patch) | |
| tree | 5a462c27ec346bd32b14ab7db70c5da4c39cf7ff /scripts/objdiff | |
| parent | f53f5c2437c1bd76fc0063a30a069a5207de8802 (diff) | |
| download | linux-6d421f609bba7b0b1a11741ec4b19feadfd27051.tar.gz linux-6d421f609bba7b0b1a11741ec4b19feadfd27051.zip | |
perf c2c: Clean up registered formats on c2c_hists__init() and c2c_hists__reinit() failure
When c2c_hists__init() or c2c_hists__reinit() calls hpp_list__parse()
and it fails partway through, format structures registered via
perf_hpp_list__column_register() and perf_hpp_list__register_sort_field()
are left on the hpp_list.
In c2c_hists__init(), only one of the callers, c2c_he__alloc_hists(),
handled this with perf_hpp__reset_output_field(), while perf_c2c_report()
did not, leaking the partially registered entries.
In c2c_hists__reinit(), neither perf_c2c_report() nor resort_cl_cb()
clean up on failure.
Fix by adding cleanup inside both functions themselves, so all callers
are protected, and remove the now redundant reset in c2c_he__alloc_hists().
Fixes: 78b275437873 ("perf c2c report: Add sample processing")
Reported-by: sashiko-bot <sashiko-bot@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Assisted-by: Claude:claude-opus-4.6
Assisted-by: Opencode:mimo-v2.5-free
Assisted-by: Opencode:DeepSeek-V4-Flash-free
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'scripts/objdiff')
0 files changed, 0 insertions, 0 deletions
