diff options
| author | Tanushree Shah <tshah@linux.ibm.com> | 2026-07-26 00:19:53 +0530 |
|---|---|---|
| committer | Namhyung Kim <namhyung@kernel.org> | 2026-08-07 09:43:36 -0700 |
| commit | 43a163494ff7aee0c8add586e54db4f1d706bf4e (patch) | |
| tree | 9c1ff526139336b92c7b71819a20049822f9b111 /scripts | |
| parent | c291f143cc495d7d46ca677a3d4f0a17c363e1a6 (diff) | |
| download | linux-43a163494ff7aee0c8add586e54db4f1d706bf4e.tar.gz linux-43a163494ff7aee0c8add586e54db4f1d706bf4e.zip | |
perf trace-event: Fix infinite loop in skip()
skip() ignores do_read()'s return value and unconditionally
subtracts the requested chunk size from 'size' on every iteration.
This was previously bounded by size being 'int': a maliciously
large 64-bit value was truncated on assignment, capping the loop
early by accident.
Now that size is size_t, a crafted file supplying a very large
size causes skip() to keep requesting BUFSIZ-sized reads and
subtracting BUFSIZ from size regardless of whether do_read()
actually succeeds, spinning indefinitely even after EOF or a read
error.
Check do_read()'s return value and break out of the loop on
failure or EOF, so forward progress is only counted when a read
actually succeeds.
Signed-off-by: Tanushree Shah <tshah@linux.ibm.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions
