diff options
| author | Ryan Chen <ryan_chen@aspeedtech.com> | 2026-08-19 09:09:19 +0800 |
|---|---|---|
| committer | Thomas Gleixner <tglx@kernel.org> | 2026-08-19 21:45:30 +0200 |
| commit | b76eee9c2157223aa4aac42ceebb563288e078aa (patch) | |
| tree | 89dbeb89d6623697f286434abc4ebcdeb77820b9 /tools/lib/python | |
| parent | 50b10bd0c2d721ad38abd1abe3acdefb6caa0944 (diff) | |
| download | linux-b76eee9c2157223aa4aac42ceebb563288e078aa.tar.gz linux-b76eee9c2157223aa4aac42ceebb563288e078aa.zip | |
irqchip/ast2700-intc: Avoid allocating in the irq_domain activate() callback
The interrupt core calls the irq_domain_activate() callback from
__setup_irq() with desc->lock held and interrupts disabled. Both
aspeed_intc1_irq_domain_activate() and aspeed_intc0_resolve_route() test a
compatible string with fwnode_device_is_compatible().
fwnode_device_is_compatible() invokes fwnode_property_match_string(), which
allocates with GFP_KERNEL. That's obviously not possible with interrupts
disabled and a raw spinlock held.
Both call sites are only ever handed OF nodes, so use
of_device_is_compatible() instead: it walks the property in place and does
not allocate.
Fixes: 07825e41519a ("irqchip/ast2700-intc: Add AST2700-A2 support")
Reported-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Tested-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Link: https://patch.msgid.link/20260819-fix-ast2700-intc-atomic-alloc-v1-1-d92a02e2a239@aspeedtech.com
Diffstat (limited to 'tools/lib/python')
0 files changed, 0 insertions, 0 deletions