1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
|
// SPDX-License-Identifier: GPL-2.0-or-later
/*
* Copyright (C) Qualcomm Technologies, Inc. and/or its subsidiaries
*/
#include <linux/array_size.h>
#include <linux/device.h>
#include <linux/fwnode.h>
#include <linux/list.h>
#include <linux/platform_device.h>
#include <linux/property.h>
#include <linux/time.h>
#include <linux/types.h>
#include <linux/wait.h>
#include <kunit/fwnode.h>
#include <kunit/platform_device.h>
#include <kunit/test.h>
static int swnode_count_suppliers(struct fwnode_handle *fwnode)
{
struct fwnode_link *link;
unsigned int count = 0;
/*
* The suppliers and consumers lists should typically only be accessed
* with the fwnode_link_lock taken but it's private to the driver core.
*
* These are tests and at this point nobody should be modifying them so
* let's just access the list.
*/
list_for_each_entry(link, &fwnode->suppliers, c_hook)
count++;
return count;
}
/* True if a supplier link con->sup exists, checked from both list ends. */
static bool swnode_has_link(struct fwnode_handle *consumer,
struct fwnode_handle *supplier)
{
bool from_con = false, from_sup = false;
struct fwnode_link *link;
list_for_each_entry(link, &consumer->suppliers, c_hook) {
if (link->supplier == supplier && link->consumer == consumer)
from_con = true;
}
list_for_each_entry(link, &supplier->consumers, s_hook) {
if (link->supplier == supplier && link->consumer == consumer)
from_sup = true;
}
return from_con && from_sup;
}
/* A single reference creates exactly one supplier link, on both list ends. */
static void swnode_devlink_test_single_ref(struct kunit *test)
{
static const struct software_node supp_swnode = {
.name = "swnode-devlink-test-supplier",
};
struct fwnode_handle *cons_fwnode, *supp_fwnode;
int ret;
const struct property_entry props[] = {
PROPERTY_ENTRY_REF("supplier", &supp_swnode),
{ }
};
supp_fwnode = kunit_software_node_register(test, &supp_swnode);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, supp_fwnode);
cons_fwnode = kunit_fwnode_create_software_node(test, props, NULL);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, cons_fwnode);
ret = fwnode_call_int_op(cons_fwnode, add_links);
KUNIT_EXPECT_EQ(test, ret, 0);
KUNIT_EXPECT_EQ(test, swnode_count_suppliers(cons_fwnode), 1);
KUNIT_EXPECT_TRUE(test, swnode_has_link(cons_fwnode, supp_fwnode));
}
/* Multiple distinct references create multiple supplier links. */
static void swnode_devlink_test_multiple_refs(struct kunit *test)
{
static const struct software_node supp1_swnode = {
.name = "swnode-devlink-test-supplier-1",
};
static const struct software_node supp2_swnode = {
.name = "swnode-devlink-test-supplier-2",
};
static const struct software_node *supp_nodes[] = {
&supp1_swnode, &supp2_swnode, NULL
};
const struct property_entry props[] = {
PROPERTY_ENTRY_REF("foo", &supp1_swnode),
PROPERTY_ENTRY_REF("bar", &supp2_swnode),
{ }
};
struct fwnode_handle *fwnode;
int ret;
ret = kunit_software_node_register_node_group(test, supp_nodes);
KUNIT_ASSERT_EQ(test, ret, 0);
fwnode = kunit_fwnode_create_software_node(test, props, NULL);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, fwnode);
ret = fwnode_call_int_op(fwnode, add_links);
KUNIT_EXPECT_EQ(test, ret, 0);
KUNIT_EXPECT_EQ(test, swnode_count_suppliers(fwnode), 2);
KUNIT_EXPECT_TRUE(test, swnode_has_link(fwnode, software_node_fwnode(&supp1_swnode)));
KUNIT_EXPECT_TRUE(test, swnode_has_link(fwnode, software_node_fwnode(&supp2_swnode)));
}
/* A reference to an unregistered node creates no link (graceful skip). */
static void swnode_devlink_test_unregistered_ref(struct kunit *test)
{
static const struct software_node supp_swnode = {
.name = "swnode-devlink-test-supplier",
};
const struct property_entry props[] = {
PROPERTY_ENTRY_REF("supplier", &supp_swnode),
{ }
};
struct fwnode_handle *fwnode;
int ret;
fwnode = kunit_fwnode_create_software_node(test, props, NULL);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, fwnode);
ret = fwnode_call_int_op(fwnode, add_links);
KUNIT_EXPECT_EQ(test, ret, 0);
KUNIT_EXPECT_EQ(test, swnode_count_suppliers(fwnode), 0);
}
/* Graph "remote-endpoint" references are excluded. */
static void swnode_devlink_test_remote_endpoint_excluded(struct kunit *test)
{
static const struct software_node ep_swnode = {
.name = "swnode-devlink-test-end-point"
};
const struct property_entry props[] = {
PROPERTY_ENTRY_REF("remote-endpoint", &ep_swnode),
{ }
};
struct fwnode_handle *cons_fwnode, *supp_fwnode;
int ret;
supp_fwnode = kunit_software_node_register(test, &ep_swnode);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, supp_fwnode);
cons_fwnode = kunit_fwnode_create_software_node(test, props, NULL);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, cons_fwnode);
ret = fwnode_call_int_op(cons_fwnode, add_links);
KUNIT_EXPECT_EQ(test, ret, 0);
KUNIT_EXPECT_EQ(test, swnode_count_suppliers(cons_fwnode), 0);
}
/* A reference array creates one link per registered element. */
static void swnode_devlink_test_ref_array(struct kunit *test)
{
static const struct software_node supp1_swnode = {
.name = "swnode-devlink-test-supplier-1",
};
static const struct software_node supp2_swnode = {
.name = "swnode-devlink-test-supplier-2",
};
static const struct software_node *supp_nodes[] = {
&supp1_swnode, &supp2_swnode, NULL
};
static const struct software_node_ref_args refs[] = {
SOFTWARE_NODE_REFERENCE(&supp1_swnode),
SOFTWARE_NODE_REFERENCE(&supp2_swnode, 4, 2),
};
const struct property_entry props[] = {
PROPERTY_ENTRY_REF_ARRAY("suppliers", refs),
{ }
};
struct fwnode_handle *fwnode;
int ret;
ret = kunit_software_node_register_node_group(test, supp_nodes);
KUNIT_ASSERT_EQ(test, ret, 0);
fwnode = kunit_fwnode_create_software_node(test, props, NULL);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, fwnode);
ret = fwnode_call_int_op(fwnode, add_links);
KUNIT_EXPECT_EQ(test, ret, 0);
KUNIT_EXPECT_EQ(test, swnode_count_suppliers(fwnode), 2);
KUNIT_EXPECT_TRUE(test, swnode_has_link(fwnode, software_node_fwnode(&supp1_swnode)));
KUNIT_EXPECT_TRUE(test, swnode_has_link(fwnode, software_node_fwnode(&supp2_swnode)));
}
/*
* End-to-end test: fw_devlink must defer a consumer's probe until its
* supplier has probed.
*
* The reference created by software_node_add_links() is only useful if the
* driver core promotes it to a real device_link and uses it to order probing.
* This test drives actual probing through the platform bus and asserts the
* supplier binds before the consumer.
*/
#define SWNODE_DEVLINK_TEST_SUPPLIER "swnode-link-supplier"
#define SWNODE_DEVLINK_TEST_CONSUMER "swnode-link-consumer"
#define SWNODE_DEVLINK_TEST_TIMEOUT_MS (2 * MSEC_PER_SEC)
struct swnode_test_probe_order {
/* Names in the order their drivers' .probe ran. */
const char *probed[2];
unsigned int count;
wait_queue_head_t wq;
};
static int swnode_test_record_probe(struct platform_device *pdev)
{
struct swnode_test_probe_order *order = platform_get_drvdata(pdev);
if (order && order->count < ARRAY_SIZE(order->probed)) {
order->probed[order->count++] = dev_name(&pdev->dev);
wake_up_interruptible(&order->wq);
}
return 0;
}
static struct platform_driver swnode_test_supplier_driver = {
.probe = swnode_test_record_probe,
.driver = {
.name = SWNODE_DEVLINK_TEST_SUPPLIER,
},
};
static struct platform_driver swnode_test_consumer_driver = {
.probe = swnode_test_record_probe,
.driver = {
.name = SWNODE_DEVLINK_TEST_CONSUMER,
},
};
static void swnode_devlink_test_probe_order(struct kunit *test)
{
static const struct software_node supplier_swnode = {
.name = "swnode-devlink-test-supplier",
};
const struct property_entry consumer_props[] = {
PROPERTY_ENTRY_REF("supplier-ref", &supplier_swnode),
{ }
};
struct platform_device *supplier, *consumer;
struct swnode_test_probe_order *order;
struct fwnode_handle *fwnode;
int ret;
order = kunit_kzalloc(test, sizeof(*order), GFP_KERNEL);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, order);
init_waitqueue_head(&order->wq);
fwnode = kunit_software_node_register(test, &supplier_swnode);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, fwnode);
ret = kunit_platform_driver_register(test, &swnode_test_supplier_driver);
KUNIT_ASSERT_EQ(test, ret, 0);
ret = kunit_platform_driver_register(test, &swnode_test_consumer_driver);
KUNIT_ASSERT_EQ(test, ret, 0);
supplier = kunit_platform_device_alloc(test, SWNODE_DEVLINK_TEST_SUPPLIER,
PLATFORM_DEVID_NONE);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, supplier);
consumer = kunit_platform_device_alloc(test, SWNODE_DEVLINK_TEST_CONSUMER,
PLATFORM_DEVID_NONE);
KUNIT_ASSERT_NOT_ERR_OR_NULL(test, consumer);
platform_set_drvdata(supplier, order);
platform_set_drvdata(consumer, order);
ret = kunit_device_add_software_node(test, &supplier->dev, &supplier_swnode);
KUNIT_ASSERT_EQ(test, ret, 0);
ret = device_create_managed_software_node(&consumer->dev,
consumer_props, NULL);
KUNIT_ASSERT_EQ(test, ret, 0);
ret = kunit_platform_device_add(test, consumer);
KUNIT_ASSERT_EQ(test, ret, 0);
ret = kunit_platform_device_add(test, supplier);
KUNIT_ASSERT_EQ(test, ret, 0);
ret = wait_event_interruptible_timeout(order->wq,
order->count == 2,
msecs_to_jiffies(SWNODE_DEVLINK_TEST_TIMEOUT_MS));
KUNIT_ASSERT_GT(test, ret, 0);
KUNIT_EXPECT_STREQ(test, order->probed[0], SWNODE_DEVLINK_TEST_SUPPLIER);
KUNIT_EXPECT_STREQ(test, order->probed[1], SWNODE_DEVLINK_TEST_CONSUMER);
/* Tear down the consumer (and its device link) before the supplier. */
kunit_platform_device_unregister(test, consumer);
}
static struct kunit_case swnode_test_cases[] = {
KUNIT_CASE(swnode_devlink_test_single_ref),
KUNIT_CASE(swnode_devlink_test_multiple_refs),
KUNIT_CASE(swnode_devlink_test_unregistered_ref),
KUNIT_CASE(swnode_devlink_test_remote_endpoint_excluded),
KUNIT_CASE(swnode_devlink_test_ref_array),
KUNIT_CASE(swnode_devlink_test_probe_order),
{ }
};
static struct kunit_suite swnode_test_suite = {
.name = "software-node-links",
.test_cases = swnode_test_cases,
};
kunit_test_suite(swnode_test_suite);
MODULE_DESCRIPTION("Test module for software node fw_devlink support");
MODULE_AUTHOR("Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>");
MODULE_LICENSE("GPL");
|