diff options
| author | Hongling Zeng <zenghongling@kylinos.cn> | 2026-05-03 12:12:43 +0800 |
|---|---|---|
| committer | John Johansen <john.johansen@canonical.com> | 2026-06-13 20:14:07 -0700 |
| commit | b7a2b49bba4e5994a476c49d662b796818079e5e (patch) | |
| tree | b3b1d4b5b15b0f24ec135f7612d1346360889a4e /security | |
| parent | 59fe6fbc4cd45582bc8893de0a382a36562317b3 (diff) | |
| download | linux-2.6-b7a2b49bba4e5994a476c49d662b796818079e5e.tar.gz linux-2.6-b7a2b49bba4e5994a476c49d662b796818079e5e.zip | |
apparmor: Fix return in ns_mkdir_op
Return NULL instead of passing to ERR_PTR while error is zero.
Fixes smatch warning:
- security/apparmor/apparmorfs.c:1846 ns_mkdir_op() warn:
passing zero to 'ERR_PTR'
Fixes: 88d5baf69082 ("Change inode_operations.mkdir to return struct dentry *")
Reviewed-by: Ryan Lee <ryan.lee@canonical.com>
Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn>
Signed-off-by: John Johansen <john.johansen@canonical.com>
Diffstat (limited to 'security')
| -rw-r--r-- | security/apparmor/apparmorfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/security/apparmor/apparmorfs.c b/security/apparmor/apparmorfs.c index a59c4b83620f..94b8c7979231 100644 --- a/security/apparmor/apparmorfs.c +++ b/security/apparmor/apparmorfs.c @@ -1975,7 +1975,7 @@ out: mutex_unlock(&parent->lock); aa_put_ns(parent); - return ERR_PTR(error); + return error ? ERR_PTR(error) : NULL; } static int ns_rmdir_op(struct inode *dir, struct dentry *dentry) |