diff options
| author | Alex Elder <elder@riscstar.com> | 2026-09-02 16:43:17 -0500 |
|---|---|---|
| committer | Bjorn Andersson <andersson@kernel.org> | 2026-09-03 09:40:12 -0500 |
| commit | ca3027cfe8c7ef612910d2f04e58d75ec8a9b427 (patch) | |
| tree | 8e2d7c8a245cc5a076370e35fea9a36f6232a8bd | |
| parent | aaedd4ea312d6fd70dfc5cf430edf5106c5b3382 (diff) | |
| download | linux-next-ca3027cfe8c7ef612910d2f04e58d75ec8a9b427.tar.gz linux-next-ca3027cfe8c7ef612910d2f04e58d75ec8a9b427.zip | |
arm64: dts: qcom: lemans-evk-ifp-mezzanine: clean up PCI function nodes
The lemans-evk-ifp-mezzanine overlay defines a node representing a
TC956x chip which contains a PCIe switch and an embedded endpoint
that implements two PCIe functions.
The devicetree nodes erroneously include a "pci" device_type property
for the two PCIe functions. That property should only be used for a
PCI device "that implements a PCI bus". Remove this property for the
two function nodes.
In addition, only PCI bridge nodes should be named "pcie@" (or "pci@").
PCI endpoint nodes are typically named based on the functionality they
implement (e.g., "ethernet@"). In this case, the role of these PCI
functions is not (yet) specified, and furthermore they will be used
with PCI endpoint buses. Rename these to use "dev@", following the
convention used in of_pci_make_dev_node() for dynamically-created
devicetree nodes.
Finally, these nodes define #address-cells, #size-cells, and ranges
properties, which are not normally defined for PCIe endpoints. Remove
these properties as well; they can be added back once they are actually
needed/used.
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Fixes: b64abb26a2916 ("arm64: dts: qcom: lemans-evk: Add IFP Mezzanine")
Signed-off-by: Alex Elder <elder@riscstar.com>
Link: https://lore.kernel.org/r/20260902214321.1721477-4-elder@riscstar.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
| -rw-r--r-- | arch/arm64/boot/dts/qcom/lemans-evk-ifp-mezzanine.dtso | 12 |
1 files changed, 2 insertions, 10 deletions
diff --git a/arch/arm64/boot/dts/qcom/lemans-evk-ifp-mezzanine.dtso b/arch/arm64/boot/dts/qcom/lemans-evk-ifp-mezzanine.dtso index 6cfa0bc1440e..e42314c64857 100644 --- a/arch/arm64/boot/dts/qcom/lemans-evk-ifp-mezzanine.dtso +++ b/arch/arm64/boot/dts/qcom/lemans-evk-ifp-mezzanine.dtso @@ -271,20 +271,12 @@ ranges; bus-range = <0x5 0xff>; - pcie@0,0 { + dev@0,0 { reg = <0x50000 0x0 0x0 0x0 0x0>; - #address-cells = <3>; - #size-cells = <2>; - device_type = "pci"; - ranges; }; - pcie@0,1 { + dev@0,1 { reg = <0x50100 0x0 0x0 0x0 0x0>; - #address-cells = <3>; - #size-cells = <2>; - device_type = "pci"; - ranges; }; }; }; |